TEST: use gcc to compile UCX in clang-tidy-rocm #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgargabriel
force-pushed
the
topic/clang-tidy-rocm-update
branch
12 times, most recently
from
e56ec76 to
2ff4656
Compare
Sergei-Lebedev
approved these changes
Sep 22, 2023
|
looks good to me, thanks for debugging the issue |
manjugv
approved these changes
Sep 25, 2023
The hip header file generates a warning when compiled with clang, which in itself is harmless, but because all warnings are treated as errors, the compilation fails in the UCX step. Compile UCX with gcc instead of clang (since we are not truly interested in running clang-tidy on ucx in this CI, but just on UCC) Furthermore, force using rocm 5.6.1 instead of the newest version
Sergei-Lebedev
force-pushed
the
topic/clang-tidy-rocm-update
branch
from
2ff4656 to
9447fa8
Compare
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
The hip header file generates a warning when compiled with clang, which in itself is harmless, but because all warnings are treated as errors, the compilation fails in the UCX step. Compile UCX with gcc instead of clang (since we are not truly interested in running clang-tidy on ucx in this CI, but just on UCC) Furthermore, force using rocm 5.6.1 instead of the newest version
nsarka
pushed a commit
to nsarka/ucc
that referenced
this pull request
Oct 24, 2023
The hip header file generates a warning when compiled with clang, which in itself is harmless, but because all warnings are treated as errors, the compilation fails in the UCX step. Compile UCX with gcc instead of clang (since we are not truly interested in running clang-tidy on ucx in this CI, but just on UCC) Furthermore, force using rocm 5.6.1 instead of the newest version
janjust
pushed a commit
to janjust/ucc
that referenced
this pull request
Jan 31, 2024
The hip header file generates a warning when compiled with clang, which in itself is harmless, but because all warnings are treated as errors, the compilation fails in the UCX step. Compile UCX with gcc instead of clang (since we are not truly interested in running clang-tidy on ucx in this CI, but just on UCC) Furthermore, force using rocm 5.6.1 instead of the newest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The hip header file generates a warning when compiled with clang, which in itself is harmless, but because all warnings are treated as errors, the compilation fails in the UCX step. Compile UCX with gcc instead of clang (since we are not truly interested in running clang-tidy on ucx in this CI, but just on UCC)
Furthermore, force using rocm 5.6.1 for now instead of the most recent rocm release, since rocm-5.7 would require clang-14